refactor: migrate avoid_unused_parameters#290
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the avoid_unused_parameters lint rule to align with the new SolidLintRule API, replacing custom lint builder APIs with RuleVisitorRegistry and RuleContext. It also introduces comprehensive unit tests and a fake analysis options loader for testing. Feedback on the changes highlights a potential issue in visitFunctionExpression where anonymous functions defined inside excluded methods or constructors are not correctly ignored, which could lead to false positives. A suggestion was provided to check for any enclosing executable declaration to resolve this.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
andrew-bekhiet-solid
force-pushed
the
248-migrate-avoid_unused_parameters
branch
from
5bb8c40 to
dd250ed
Compare
andrew-bekhiet-solid
merged commit addb4b3
into
analysis_server_migration
2 participants
removes
LintCodeCopyWithso the tests can compile, can be re-added laterimproves code comments
adds
FakeAnalysisOptionsLoaderto help in testing